fix(ci): drop i686 builds (pulp lacks 32-bit support)#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
mainis failing on the two 32-bit (i686) build jobs:build on linux (i686 - all - manylinux)build on windows (i686 - ...)Both fail with:
Root cause
PR #85 (linear sum assignment) added
perfect-matching = "0.1.0"topowerboxesrs. Dependency chain:pulpis a SIMD crate that emits x86-64-only inline asm (vmovss xmm0, [rax + 0]) and cannot compile for 32-bit targets.perfect-matchingdepends onpulpunconditionally (no feature gate), so there's no way to opt out while keeping the LSAP feature.Fix
Drop the
linux/i686andwindows/i686entries from thebuildmatrix in.github/workflows/ci.yml. This is the minimal change to unblockmain.Trade-off: powerboxes will no longer publish 32-bit wheels (it did in older 0.1.x releases). Acceptable given the new LSAP dependency can't build for those targets.
🤖 Generated with Claude Code