Open
Conversation
This makes it easier to use from clients, they don’t have to create their SimpleGlobal any longer.
It simplifies the code quite a bit.
PolyMeilex
reviewed
Aug 4, 2023
Comment on lines
+90
to
+100
| /* | ||
| /// Set the source rectangle. | ||
| pub fn set_source(&self, x: f64, y: f64, width: f64, height: f64) { | ||
| self.viewport.set_source(x, y, width, height); | ||
| } | ||
|
|
||
| /// Set the destination size. | ||
| pub fn set_destination(&self, width: i32, height: i32) { | ||
| self.viewport.set_destination(width, height); | ||
| } | ||
| */ |
Member
There was a problem hiding this comment.
Can we uncomment those?
It would be good to use this wrapper instead of WlVieporter directly, as that would allow for addition of version guards when a new version of viewporter releases some day.
Contributor
There was a problem hiding this comment.
Is there any point to Viewport to begin with? Just getting the viewport from the state and using that is all you need really. My personal implementations never used more than that (https://github.com/catacombing/kumo/blob/master/src/wayland/protocols/viewporter.rs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies client code quite a bit.