Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Crafter library documentation by adding a new page for flags and reorganizing the function tag documentation. The changes improve documentation clarity by moving advanced features into dedicated sections.
- Adds comprehensive documentation for crafting flags (consume_buckets, consume_tools)
- Documents the
#smithed.crafter:event/query_tagsfunction tag with usage examples - Reorganizes advanced uses section by moving specific features to dedicated pages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/libraries/crafter/index.md | Adds new flags page to the documentation table of contents |
| docs/libraries/crafter/function_tag.md | Adds query_tags event documentation and updates advanced uses section with corrected links |
| docs/libraries/crafter/flags.md | New file documenting flag system for customizing item removal during crafting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/libraries/crafter/flags.md
Outdated
| | 'Success of operation' | score | $temp | smithed.data | | ||
| | 'Item to replace in the crafter' | entity | @s | weapon.mainhand | | ||
|
|
||
| The default value of 'Success of operation' is 0, which by default juste remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. |
There was a problem hiding this comment.
There's a spelling error in "juste" which should be "just".
Suggested change
| The default value of 'Success of operation' is 0, which by default juste remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. | |
| The default value of 'Success of operation' is 0, which by default just remove one item. This whould be the default behavior if your flag is not present. If your flag is present and you want to change the item, set it to 1. |
edayot
commented
Mar 29, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
edayot
commented
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.