Render broken symlinks & show symlinks in different colors

[nikitakrh]

Closes #24

Changes

Backend (local_fs.py, models.py):

• FSItem gets isBrokenSymlink and symlinkTarget fields.
• scandir now catches OSError on broken symlinks instead of crashing.
• Broken symlinks are included with isBrokenSymlink=True, working symlinks can be found via isBrokenSymlink == False and symlinkTarget is not None.

Frontend (folderTreeSlice.ts, FolderTreeView.tsx, TreeNodeComponent.tsx, iconUtils.tsx):

• Propagate the two new fields through the tree state.
• In the tree node:
  • Broken symlinks get a FileX icon (red) and red text
  • Working symlinks show blue text
  • Both display the target as name (→ target) with a tooltip

Example:

[nikitakrh]

Some more background: I basically took the bugfix_2.patch @jonded94 posted in the issue #24 and applied it to the most recent main. I added 2 more features which is the displaying of the symlinked path and the blue color for working symlinks.

Happy to answer any questions or get feedback on this PR! 🙏

[jonded94]

I think your version here is a bit too much based on the vibe-coded version I showcased in this comment.

I'd reduce the scope of the try statement to just the entry.stat() to both make intent clearer as well as don't unnecessarily catch other exceptions that shouldn't be caught.

Also, I'd personally always rather see what exceptions happened and therefore include the stack trace (either through exc_info or by using logger.exception). But that is for @slinjhu to decide 😄

Suggested change

	try:
	stat = entry.stat()
	all_items.append(
	FSItem(
	name=entry.name,
	size=stat.st_size,
	lastModified=int(1000 * stat.st_mtime),
	isDir=entry.is_dir(),
	symlinkTarget=os.readlink(entry.path) if entry.is_symlink() else "",
	)
	)
	)
	except OSError:
	if entry.is_symlink():
	all_items.append(
	FSItem(
	name=entry.name,
	size=0,
	lastModified=0,
	isDir=False,
	isBrokenSymlink=True,
	symlinkTarget=os.readlink(entry.path),
	)
	)
	else:
	logger.warning(f"Failed to stat entry: {entry.path}")
	try:
	stat = entry.stat()
	except OSError:
	if entry.is_symlink():
	all_items.append(
	FSItem(
	name=entry.name,
	size=0,
	lastModified=0,
	isDir=False,
	isBrokenSymlink=True,
	symlinkTarget=os.readlink(entry.path),
	)
	)
	else:
	logger.exception(f"Failed to stat entry: {entry.path}")
	else:
	all_items.append(
	FSItem(
	name=entry.name,
	size=stat.st_size,
	lastModified=int(1000 * stat.st_mtime),
	isDir=entry.is_dir(),
	symlinkTarget=os.readlink(entry.path) if entry.is_symlink() else "",
	)
	)

[slinjhu]

Makes sense. In general it is better to keep try-catch scope smaller.

[nikitakrh]

Agreed, I applied the suggestion.

[slinjhu]

Thanks @nikitakrh for the great work. I wasn't anticipating broken symlink, thanks for floating up this corner case in realistic data.

@jonded94 made a suggestion to reduce scope of try-catch, and I think it makes sense and increase code readability.

Otherwise your PR looks good to me.

[slinjhu]

Change logger.warning to logger.exception so we can see full traceback

[nikitakrh]

Changed it to exception 🙂

[slinjhu]

Makes sense. In general it is better to keep try-catch scope smaller.

[slinjhu]

Tests failing due to lack of AWS credentials. After some research I fount issue:

This is a GitHub security restriction: when a PR comes from a fork (nikitakrh's
repo), GitHub intentionally does not pass secrets to the workflow. So ${{ secrets.AWS_ACCESS_KEY_ID }} resolves to
empty, regardless of what's in your env block.

When you push directly to main, the workflow runs in your own repo context and secrets work fine.

[slinjhu]

Released v0.1.47