Skip to content

Conversation

@kmontemayor2-sc
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Jan 13, 2026

Scope of work done

Please focus your reviews on the code under examples/link_prediction/graph_store. Everything else should be reviewed in other prs (mainly #432 )

Specifically, examples/link_prediction/graph_store/homogeneous_inference.py is the most important file here.

As a follow up to this I will make it so users can customize the server code.

The main differences between this code and the "colocated" mode (which should be documented in the docstring) are:

  1. Calling init_compute_node to setup the entire heterogeneous training cluster
  2. Using GraphStoreInfo to capture the cluster topology
  3. Using RemoteDistDataset instead of DistDataset as a pointer to the DistDataset stored on the storage cluster.

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

GiGL Automation

@ 18:04:16UTC : 🔄 E2E Test started.

@ 18:24:09UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

GiGL Automation

@ 18:25:14UTC : 🔄 E2E Test started.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

GiGL Automation

@ 21:17:12UTC : 🔄 E2E Test started.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

GiGL Automation

@ 21:27:12UTC : 🔄 E2E Test started.

@ 22:21:44UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

GiGL Automation

@ 23:48:00UTC : 🔄 E2E Test started.

@ 24:51:24UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc kmontemayor2-sc changed the title Kmonte/gs homo e2e inf Setup e2e integration test for graph store homogeneous inference Jan 15, 2026
@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

GiGL Automation

@ 01:37:59UTC : 🔄 E2E Test started.

@ 03:05:51UTC : ✅ Workflow completed successfully.

Copy link
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!
Really excited to see this go in 😄

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

GiGL Automation

@ 18:09:54UTC : 🔄 E2E Test started.

@ 19:30:12UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

GiGL Automation

@ 19:41:53UTC : 🔄 E2E Test started.

@ 21:05:18UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

GiGL Automation

@ 21:14:23UTC : 🔄 E2E Test started.

@ 22:40:21UTC : ❌ Workflow failed.
Please check the logs for more details.

Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Kyle!

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

GiGL Automation

@ 22:51:05UTC : 🔄 E2E Test started.

@ 24:15:14UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

GiGL Automation

@ 24:31:34UTC : 🔄 E2E Test started.

@ 01:55:46UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review January 21, 2026 16:57
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 33b109d Jan 21, 2026
6 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/gs-homo-e2e-inf branch January 21, 2026 18:24
zfan3-sc pushed a commit that referenced this pull request Jan 21, 2026
Co-authored-by: kmontemayor <kyle.e.montemayor@gmail.com>
zfan3-sc pushed a commit that referenced this pull request Jan 21, 2026
Co-authored-by: kmontemayor <kyle.e.montemayor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants