Fix Oid signed overflow in format strings producing negative values#382
Open
sfc-gh-npuka wants to merge 1 commit into
Open
Fix Oid signed overflow in format strings producing negative values#382sfc-gh-npuka wants to merge 1 commit into
sfc-gh-npuka wants to merge 1 commit into
Conversation
Oid is unsigned int, but several format strings used %d (signed) instead of %u, causing OIDs above INT_MAX to appear negative in S3 paths, sequence names, and temp table names. Signed-off-by: sfc-gh-npuka <naisila.puka@snowflake.com>
| const char *relationName = GetRestCatalogTableName(relationId); | ||
|
|
||
| appendStringInfo(location, "%s/%s/%s/%s/%d", IcebergDefaultLocationPrefix, catalogName, namespaceName, relationName, relationId); | ||
| appendStringInfo(location, "%s/%s/%s/%s/%u", IcebergDefaultLocationPrefix, catalogName, namespaceName, relationName, relationId); |
Collaborator
There was a problem hiding this comment.
two questions:
- Would this break existing tables
- Can we add a test? We should be able to get the location of the table from the REST catalog and make sure the OID is non-negative value
Collaborator
There was a problem hiding this comment.
this determines location at create time, right? so wouldn't affect existing tables
| RowIdSequenceGetRangeVar(Oid relationId) | ||
| { | ||
| char *sequenceName = psprintf("rowid_%d_seq", relationId); | ||
| char *sequenceName = psprintf("rowid_%u_seq", relationId); |
Collaborator
There was a problem hiding this comment.
could this break existing tables with row-ids?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oid is unsigned int, but several format strings used %d (signed) instead of %u, causing OIDs above INT_MAX to appear negative in S3 paths, sequence names, and temp table names.