Skip to content

Adding resource layout setting#23

Open
ask-andrew1 wants to merge 3 commits intoSnsei987:mainfrom
Nangzdk1:resource-layout
Open

Adding resource layout setting#23
ask-andrew1 wants to merge 3 commits intoSnsei987:mainfrom
Nangzdk1:resource-layout

Conversation

@ask-andrew1
Copy link

Summary

This adds a setting dropdown to the Bar Settings that will change the Layout direction for fragmented power types. This also add the other Ticked Power Types as Fragmented Power Types to support the same functionality. The dropdown options are Auto, Horizontal and Vertical.

  • Auto - maintains the current functionality and is the default.
  • Vertical - Using runes as an example, this would display them vertically in a single column, the same as Fill Direction bottom to top/top to bottom previously did, except now you can do Fill Direction left to right/right to left while vertical.
  • Horizontal - Using runes as an example, this causes them to display in a single row right to left the same way it previously did on Fill Direction right to left/left to right, except now you can have the individual runes filling Fill Direction bottom to top or top to bottom.

Simple bars such as most primary resources are unaffected by this layout setting and continue to respect Fill Direction exclusively.

Testing Steps

  1. Switch to this branch while playing a character with one of the fragmented power types.
  2. Edit Mode -> Secondary Resource Bar (unless on Enhance Shaman for Maelstrom Weapon) -> Bar Settings -> and confirm the Fill Direction dropdown behaves as expected while Fragmented Resource Layout is set to Auto
  3. Change the Fragmented Resource Layout to Vertical and note the behavior differences as you cycle through different Fill Directions.
  4. Repeat for Horizontal.
  5. Repeat on other classes that were modified to confirm behavior remains consistent and appropriate.
  6. Done.

adding additional fragmented power types to handle orientation flipping

renaming to more user friendly name
@ask-andrew1
Copy link
Author

Hey @Sensei987 No rush at all, but I have rebased and resolved conflicts with main. I'm happy to make any changes or updates if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant