feat: add ten Maelstrom Weapon ticks and configurable highlight threshold for Enhancement Shaman by LorenzenLars · Pull Request #65 · Snsei987/SenseiClassResourceBar

LorenzenLars · 2026-01-26T08:00:40Z

This pull request adds a new feature for Enhancement Shamans:

A checkbox to enable 10-tick Maelstrom Weapon bar (default 5 ticks)
A slider to set the highlight threshold for the Maelstrom Weapon bar (default >=6, adjustable 6-10)
The 10-tick option and slider are only enabled for Enhancement Shamans
Bar Visuals update immidiatly when toggling the 10-tick bar or changing the threshold
Existing behavior for 5-tick bar (original) remains unchanged for other specs and classes

This change adds a bit of customization for Enhancement Shamans tracking Maelstrom Weapon stacks.

Tested in-game with Enhancement Specialization. Not enabled when playing other classes or other shaman specs.
Located under Bar Style in Edit Mode (Not sure about the placement there though) - Can be moved if like the changes but wants the settings elsewhere.

…hold for Enhancement Shaman

Snsei987 · 2026-01-26T12:23:19Z

Hi, thanks. Can you remove the slider to change the threshold please, I intend to something for that. I will accept the 10 bars mode though.

LorenzenLars · 2026-01-26T13:14:44Z

Hi, thanks. Can you remove the slider to change the threshold please, I intend to something for that. I will accept the 10 bars mode though.

Removed the slider and everything related to threshold. Now it's just a toggle for using 10 bar for maelstrom. Threshold is back to "> 5" whether it's 5 or 10 bars.

Snsei987

Most of the time you can do something quicker because data is not null, so no need to check against that.

Snsei987 · 2026-01-26T13:39:29Z

Bars/SecondaryResourceBar.lua

+                    local specID = C_SpecializationInfo.GetSpecializationInfo(spec)
+                    return playerClass == "SHAMAN" and specID == 263
+                end,
+                tooltip = L["USE_TEN_TICK_MAELSTROM_BAR"],


Suggested change

tooltip = L["USE_TEN_TICK_MAELSTROM_BAR"],

No need.

Snsei987 · 2026-01-26T13:40:05Z

Bars/SecondaryResourceBar.lua

+
+                    local data = SenseiClassResourceBarDB[dbName][layoutName]
+                    data.maelstromWeaponUseTenBars = value
+
+                    bar:ApplyLayout(layoutName)
+


Suggested change

local data = SenseiClassResourceBarDB[dbName][layoutName]

data.maelstromWeaponUseTenBars = value

bar:ApplyLayout(layoutName)

SenseiClassResourceBarDB[dbName][layoutName].maelstromWeaponUseTenBars = value

bar:ApplyLayout(layoutName)

Snsei987 · 2026-01-26T13:40:35Z

Bars/SecondaryResourceBar.lua

+
+                end,
+                isEnabled = function(layoutName)
+                    local _, playerClass = UnitClass("player")


Suggested change

local _, playerClass = UnitClass("player")

local playerClass = select(2, UnitClass("player"))

Snsei987 · 2026-01-26T13:40:55Z

Bars/SecondaryResourceBar.lua

+                    local _, playerClass = UnitClass("player")
+                    local spec = C_SpecializationInfo.GetSpecialization()
+                    local specID = C_SpecializationInfo.GetSpecializationInfo(spec)
+                    return playerClass == "SHAMAN" and specID == 263


Suggested change

return playerClass == "SHAMAN" and specID == 263

return playerClass == "SHAMAN" and specID == 263 -- Enhancement

Snsei987 · 2026-01-26T13:43:36Z

Bars/SecondaryResourceBar.lua

@@ -139,7 +139,14 @@
        local current = auraData and auraData.applications or 0
        local max = 10


Suggested change

local max = 10

local max = data.maelstromWeaponUseTenBars and 10 or 5

Snsei987 · 2026-01-26T13:43:47Z

Bars/SecondaryResourceBar.lua

+        local data = self:GetData()
+        local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
+
+        if maelstromWeaponUseTenBars then
+            return max, current
+        else
+            return max / 2, current
+        end


Suggested change

local data = self:GetData()

local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars

if maelstromWeaponUseTenBars then

return max, current

else

return max / 2, current

end

return max, current

Snsei987 · 2026-01-26T13:45:01Z

Bars/Abstract/Bar.lua

+    local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
+
+    local maxPower
+    if resource == "MAELSTROM_WEAPON" then
+        maxPower = maelstromWeaponUseTenBars and 10 or 5


Suggested change

local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars

local maxPower

if resource == "MAELSTROM_WEAPON" then

maxPower = maelstromWeaponUseTenBars and 10 or 5

local maxPower

if resource == "MAELSTROM_WEAPON" then

maxPower = data.maelstromWeaponUseTenBars and 10 or 5

Tried inlining data.maelstromWeaponUseTenBars as suggested, but in testing it caused incorrect bar filling for the ten tick bar. Coloring only the first 5 bars, even at 10 maelstrom.

The current implementation keeps the behavior as expected and stable in-game, so i have kept it as is.

If there is another preferred pattern for guarding against data being nil during refresh, i am happy to adjust.

Use this in the getter in the file SecondaryResourceBar.lua l.401

local data = SenseiClassResourceBarDB[dbName][layoutName] if data and data.maelstromWeaponUseTenBars ~= nil then return data.maelstromWeaponUseTenBars else return defaults.maelstromWeaponUseTenBars end

This will assure you always have something

Snsei987 · 2026-01-26T13:45:38Z

Bars/Abstract/Bar.lua

+        local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
+        maxPower = maelstromWeaponUseTenBars and 10 or 5


Suggested change

local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars

maxPower = maelstromWeaponUseTenBars and 10 or 5

maxPower = data.maelstromWeaponUseTenBars and 10 or 5

Snsei987 · 2026-01-26T13:45:59Z

Bars/Abstract/Bar.lua

+        local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
+        max = maelstromWeaponUseTenBars and 10 or 5


Suggested change

local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars

max = maelstromWeaponUseTenBars and 10 or 5

max = data.maelstromWeaponUseTenBars and 10 or 5

Snsei987

Check the formats option for the text, I think they are broken.

Snsei987 · 2026-01-26T21:51:58Z

Bars/Abstract/Bar.lua

+    local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
+
+    local maxPower
+    if resource == "MAELSTROM_WEAPON" then
+        maxPower = maelstromWeaponUseTenBars and 10 or 5


Use this in the getter in the file SecondaryResourceBar.lua l.401

local data = SenseiClassResourceBarDB[dbName][layoutName] if data and data.maelstromWeaponUseTenBars ~= nil then return data.maelstromWeaponUseTenBars else return defaults.maelstromWeaponUseTenBars end

This will assure you always have something

…-ten-tick-maelstrom-bar

- Fix text formatting to adjust to max maelstrom weapon buffs - Auto-disable 10-tick bar if Raging Maelstrom talent is unlearned - 10-tick bar can only be enabled if Raging Maelstrom talent is learned

feat: add ten Maelstrom Weapon ticks and configurable highlight thres…

1d7e639

…hold for Enhancement Shaman

refactor: remove maelstrom weapon threshold slider

3a2395d

Snsei987 reviewed Jan 26, 2026

View reviewed changes

refactor: apply review feedback

fce4a01

Snsei987 reviewed Jan 26, 2026

View reviewed changes

LorenzenLars added 3 commits January 27, 2026 07:24

Merge remote-tracking branch 'upstream/main' into feature/enhancement…

c395ab9

…-ten-tick-maelstrom-bar

Merge remote-tracking branch 'upstream/main' into feature/enhancement…

7bc21e4

…-ten-tick-maelstrom-bar

refactor: apply review feedback v2

3644e90

- Fix text formatting to adjust to max maelstrom weapon buffs - Auto-disable 10-tick bar if Raging Maelstrom talent is unlearned - 10-tick bar can only be enabled if Raging Maelstrom talent is learned

	local _, playerClass = UnitClass("player")
	local playerClass = select(2, UnitClass("player"))

	return playerClass == "SHAMAN" and specID == 263
	return playerClass == "SHAMAN" and specID == 263 -- Enhancement

		@@ -139,7 +139,14 @@
		local current = auraData and auraData.applications or 0
		local max = 10

	local max = 10
	local max = data.maelstromWeaponUseTenBars and 10 or 5

		local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
		maxPower = maelstromWeaponUseTenBars and 10 or 5

	local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
	maxPower = maelstromWeaponUseTenBars and 10 or 5
	maxPower = data.maelstromWeaponUseTenBars and 10 or 5

		local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
		max = maelstromWeaponUseTenBars and 10 or 5

	local maelstromWeaponUseTenBars = data and data.maelstromWeaponUseTenBars
	max = maelstromWeaponUseTenBars and 10 or 5
	max = data.maelstromWeaponUseTenBars and 10 or 5

Conversation

LorenzenLars commented Jan 26, 2026

Uh oh!

Snsei987 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LorenzenLars commented Jan 26, 2026

Uh oh!

Snsei987 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Snsei987 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Snsei987 commented Jan 26, 2026 •

edited

Loading