Add "Use Blizzard Bar" feature for secondary resource bar

[ddavyd0v]

Adds option to replace custom secondary resource bar with Blizzard's default bar

Tested with multiple classes:

Edit mode:

[ryknuth]

Yes, I love it so much!!!!

[ryknuth]

I noticed that rogue is not perfectly centered. This might be a WoW problem. I'm not sure if something can be done.

[Skeletor-gh]

This would fix a lot of issues linked to the secondary resource bar.

[ddavyd0v]

I noticed that rogue is not perfectly centered. This might be a WoW problem. I'm not sure if something can be done.

Got around to fix it, now properly works and automatically centers at 5, 6 or 7 cp

[ryknuth]

@Sensei987 can we get eyes on this?

[ryknuth]

@Sensei987 can we get this merged in?

[ddavyd0v]

I have been playing on this branch for a bit, didn't notice any issues, would appreciate a code review, @Snsei987

[Snsei987]

I think I tested your code at some point and found something weird in Edit Mode. The bar was still visible behind, was that intended or fixed ?

[ddavyd0v]

I think I tested your code at some point and found something weird in Edit Mode. The bar was still visible behind, was that intended or fixed ?

Addressed the comment.
I think I fixed the bar being visible in Edit mode some time ago, resource text is now also not visible, see

[Snsei987]

Tested it, works mostly fine though I cannot seem to be able to drag & drop at all, no matter the "Relative Frame" value. It also breaks with ElvUI. Having that with ElvUI enabled gives a weird result :

I think this is because the original frame is removed / hidden by ElvUI. So maybe you need to create your own with a template if possible and hide the frame. i.e if "Use Blizzard Bar" is enabled, it should force enable "Hide Blizzard UI" and maybe create another frame on top of the self.Frame, display it and hide self.Frame. Though I am worried about other logic like the "Position" or "Relative Frame".

ElvUI is quite popular so I think it is important for the addon to work with it. Maybe hide the setting and force disable it if ElvUI (or somilar, maybe have a check to see if the frame exists) is loaded.

[ddavyd0v]

Thanks for flagging ElvUI compatibility issue, didn't think of that!
I changed the logic so it now reparents resource bar out of PlayerFrame so ElvUI doesn't interfere with it.
It also allowed to get rid of those weird 0 timeout hacks. Probably due to that drag and drop now also works properly from what I have tested.

[ryknuth]

@Sensei987 thanks for looking at this! Any chance to have this merged into before early access!?

[ddavyd0v]

@Sensei987 thanks for looking at this! Any chance to have this merged into before early access!?

JFYI, you are tagging incorrect user 😁, it is @Snsei987
Also you can use this branch directly in the meantime, and if you are using addon manager like CurseForge you can set the addon as ignored so it doesn't get overwritten when you do "Update All"

[Snsei987]

Need to check it, so probably not before early access but maybe before full release.

PS : Both users are me, so I receive notification of both.

[ryknuth]

@ddavyd0v can you pull the commits from main into your branch?

[ryknuth]

@Snsei987 have you had a chance to check this?