feat: migrate patch command to @socketsecurity/socket-patch@1.2.0 #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| if (!result.ok) { | ||
| process.exitCode = 1 | ||
| } |
There was a problem hiding this comment.
Error messages silently discarded on spawn failure
Medium Severity
When spawnSocketPatch fails (e.g., network error downloading the package, invalid local path, permission issues), the error message is captured in result.message but never displayed to the user. The code only sets process.exitCode = 1 without outputting the error. Other commands in the codebase properly handle this by calling logger.fail() with the message. Users will experience silent failures with exit code 1 but no explanation of what went wrong.
jdalton
force-pushed
the
feat/migrate-to-socket-patch
branch
7 times, most recently
from
ba8a337 to
aee59b7
Compare
jdalton
force-pushed
the
feat/migrate-to-socket-patch
branch
2 times, most recently
from
453e76a to
174fe73
Compare
jdalton
force-pushed
the
feat/migrate-to-socket-patch
branch
from
174fe73 to
92f1cca
Compare
- Replace 'info' test (removed command) with 'scan' (renamed from discover) - Replace 'discover' test with 'scan' (renamed) - Replace 'download' test with 'get' (download is alias) - Replace 'cleanup' test with 'repair' (renamed) - Replace 'rm' test with 'remove' (renamed) These changes align tests with socket-patch v1.2.0 command structure.
…te limiting" This reverts commit 92f1cca.
…ate limiting" This reverts commit 7fb6023.
Resolved conflict in CHANGELOG.md by keeping all changes: - Changed: Updated to @socketsecurity/socket-patch@1.2.0 - Changed: Updated Coana CLI to v14.12.148 - Fixed: Heap overflow prevention in large monorepo scans
Version getters should fail if environment variables aren't set, even in test mode, because values should be properly defined in external-tools.json.
Removed tests for commands not in socket-patch v1.2.0: - cleanup (obsolete, repair is the actual command) - discover (obsolete, scan is the actual command) - info (obsolete, merged into get command) - download (obsolete, alias of get command) Renamed: - cmd-patch-rm.test.mts → cmd-patch-remove.test.mts socket-patch v1.2.0 actual commands: get, apply, rollback, remove, list, scan, setup, repair
Added INLINED_SOCKET_CLI_COANA_VERSION, INLINED_SOCKET_CLI_SFW_VERSION, and INLINED_SOCKET_CLI_SOCKET_PATCH_VERSION to .env.test so unit tests can access these values without going through the build process.
jdalton
force-pushed
the
feat/migrate-to-socket-patch
branch
from
0d338b4 to
85db681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate patch command to use external socket-patch@1.2.0 package.
Note
Shifts patch functionality to the external Socket Patch CLI and wires up version/env plumbing.
socket patchnow forwards all args to@socketsecurity/socket-patch@1.2.0viaspawnSocketPatch(DLX or local override)socket-patchtoexternal-tools.jsonand inlined build metadataINLINED_SOCKET_CLI_SOCKET_PATCH_VERSIONgetSocketPatchVersion,SOCKET_CLI_SOCKET_PATCH_LOCAL_PATH; exports integrated inconstants/env.mtsutils/socket-patch/spawn.mtspasses org slug, API token, and proxy to the external CLIcommands/patch-old/*for reference/compatibilityWritten by Cursor Bugbot for commit 69011b8. Configure here.