fix(api-keys): reuse shared copy button for created keys#432
fix(api-keys): reuse shared copy button for created keys#432Soju06 merged 1 commit intoSoju06:mainfrom
Conversation
Soju06
left a comment
There was a problem hiding this comment.
Clean refactor replacing the inline clipboard logic with the shared CopyButton component. Approving.
- Shared
CopyButtonalready has error handling (toast.error("Failed to copy")) which the previous inline version was missing — this is the user-facing improvement behind #127. - Removes 36 lines of duplicated component code and drops 2 lucide imports.
- Frontend-only, no collisions with recently merged #421.
- CI 18/18 green.
Merging into the v1.13.2 batch.
|
@codex review (Post-merge audit — missed the pre-merge review step. Triggering now; any findings will be addressed in a follow-up PR.) |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@all-contributors please add @stemirkhan for code, test (Contributions across #422, #425, #432 — all merged in v1.14.0. Picker UX, request-logs plan column, and the API-key CopyButton refactor that fixes #127.) |
|
I've put up a pull request to add @stemirkhan! 🎉 |
Summary
CopyButtonnavigator.clipboard.writeText(...)directlyWhy
The API key created dialog had its own minimal clipboard implementation with no error handling or user feedback on failure. Reusing the shared copy control makes the behavior consistent across browsers and aligns this dialog with the rest of the frontend.
Testing
Notes