fix(codex): allow backend responses image_generation tools#445
Open
fix(codex): allow backend responses image_generation tools#445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent Codex clients advertise a top-level
image_generationtool on/backend-api/codex/responses.codex-lbstill routes backend Codex Responses payloads through shared request validation, so those requests fail locally withinvalid_request_errorbefore they reach the upstream service.This change keeps the fix backend-Codex-specific by introducing route-scoped built-in tool validation. Backend Codex Responses requests can advertise
image_generation, while/v1/responsesand/v1/chat/completionsremain strict.What Changed
/backend-api/codex/responsesand/internal/bridge/responseshandling to normalize raw payloads with the backend-onlyimage_generationallowanceresponse.createpreparation for/backend-api/codex/responses/v1/responsesvalidation strict and preserved existing tool alias normalization such asweb_search_preview/v1rejectionopenspec/changes/support-codex-image-generation-toolImpact
/backend-api/codex/responsesnow accepts and forwards{"type":"image_generation"}unchanged/v1/*behavior is unchangedValidation
openspec validate --specs.venv/bin/python -m pytest tests/unit/test_openai_requests.py tests/integration/test_proxy_responses.py tests/integration/test_proxy_websocket_responses.py -q