fix(hook): relocate detect.js to skill resource for team compatibility#5
Merged
fix(hook): relocate detect.js to skill resource for team compatibility#5
Conversation
The hook command previously pointed to the npm package's ephemeral cache path (e.g. /tmp/bunx-501-knowpatch@latest/...), making it unusable for other team members in project-scoped installations. detect.js is now bundled as a skill resource at .agents/skills/knowpatch/bin/detect.js and copied alongside SKILL.md and corrections during install. Hook commands use scope-aware paths: - project scope: relative path (node .agents/skills/knowpatch/bin/detect.js) - user scope: absolute path (node ~/.agents/skills/knowpatch/bin/detect.js) The update system detects stale hooks and migrates them automatically.
Soju06
changed the title
The detect.js build output moved from bin/ to skills/knowpatch/bin/. Update CI and release workflow verification steps to check the new path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect.js)을 npm 패키지 임시 경로에서 스킬 설치 디렉토리(.agents/skills/knowpatch/bin/)로 이동Changes
.gitignoreskills/knowpatch/bin/빌드 아티팩트 제외package.jsonskills/knowpatch/bin/으로 변경src/hooks/detect.tsfindPackageRoot()→import.meta.url기반 상대 경로 해석src/core/paths.tsgetHookCommand(scope)— project=상대, user=절대src/core/hooks.tsisPlatformHookUpToDate()추가src/core/status.tshookUpToDate필드 추가src/commands/update.tstests/paths.test.tsTest plan
tsc --noEmit통과bun test114 tests 통과bun run build→skills/knowpatch/bin/detect.js생성 확인npm pack --dry-run→ 패키지에 포함 확인