add the dataclasses for object metadata and conftest#14
Conversation
|
@lboeman @wholmgren what do you think about dataclasses? They are nice because they can be "frozen" and be accessed easily. They will require python 3.7 though. |
wholmgren
left a comment
There was a problem hiding this comment.
Based only on an hour of research into dataclasses, I'd say that they seem useful for defining the containers in the datamodel. Alternatives are standard classes, dicts, namedtuples. Aside from version compatibility, I don't see an advantage to a standard class or namedtuple for this application. dicts are nice because they are so simple, but perhaps too flexible.
requiring 3.7 is pretty aggressive, but I'm not opposed.
|
@cwhanse @dplarson @awig Do any of you have reactions to using |
|
We have had issues testing pvlib in py3.7, although off the top of my head, I can't recall what they are. Something related to numpy functions. |
|
@cwhanse I think pvlib/pvlib-python#634 solved those issues. I've been using 3.7 in some conda environments for the last few months without issues. |
|
That was my reaction. For me |
|
@wholmgren Seems like 3.7 is ok. Availability and curtailment were added. anything else? |
|
merge/rebase on master so your test runs |
with examples of what metadata, observations, and forecasts will look like
c2a2f3f to
e66652e
Compare
with examples of what metadata, observations, and forecasts will look like
closes #12