feat: Add MinIO file listing and document reading endpoints (BRIC-9)#11
Merged
feat: Add MinIO file listing and document reading endpoints (BRIC-9)#11
Conversation
…zberg integration (BRIC-9) - Add DocumentReaderPort abstract interface and KreuzbergAdapter implementation - Add list_files endpoint (GET /api/v1/files/list) and MCP tool - Add read_file endpoint (POST /api/v1/files/read) and MCP tool - Support 91 file formats via Kreuzberg document extraction - Add path traversal validation for security - Add FileInfo dataclass to StoragePort for rich file metadata - Add S3Error handling to list_objects and list_files_metadata - Comprehensive unit and integration tests - Update README with new endpoints and architecture diagram
Collaborator
Author
🟢 Code Review — BRIC-9: MinIO file listing & Kreuzberg reading✅ Points positifs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/files/listendpoint andlist_filesMCP tool to browse MinIO files without indexingPOST /api/v1/files/readendpoint andread_fileMCP tool to extract text content from MinIO files using Kreuzberg (91 file formats)DocumentReaderPort→KreuzbergAdapter,StoragePort.list_files_metadata()→MinioAdapterAcceptance Criteria Met
Definition of Done