feat: concurrent document indexing in index_folder (BRIC-8)#9
Merged
Conversation
Replace sequential for-loop with asyncio.Semaphore + asyncio.gather, bounded by MAX_CONCURRENT_FILES config. Dead code removed (103 lines). 6 new tests verify concurrency, edge cases, and mixed success/failure.
Collaborator
Author
🟢 Code Review — BRIC-8: Concurrent document indexing✅ Points positifs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the sequential
forloop inLightRAGAdapter.index_folderwithasyncio.Semaphore+asyncio.gatherto process documents concurrently, bounded by the existingMAX_CONCURRENT_FILESconfig.Changes
src/infrastructure/rag/lightrag_adapter.py: Replaced sequential loop with concurrent pattern usingasyncio.Semaphore(max(1, MAX_CONCURRENT_FILES))+asyncio.gather. Removed 103 lines of dead code.tests/unit/test_lightrag_adapter.py: Added 6 tests verifying: semaphore enforcement, zero-concurrency, excess capacity, single file, and mixed success/failure.Acceptance Criteria (BRIC-8)
All 10 acceptance criteria verified.
Testing
Jira
BRIC-8