fix(ci): pnpm setup ordering#899
Open
ssynowiec wants to merge 5 commits into
Open
Conversation
ssynowiec
added
bug
github actions
kguzek
requested changes
May 12, 2026
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| ${manager.name === "pnpm" ? `${pnpmSetupCi({ pnpmVersion })}\n` : ""} |
Member
There was a problem hiding this comment.
tak jak wspominałem, przetestowałym na nowym projekcie i w miejscu pnpm setup jest teraz podwójny newline
Member
Author
There was a problem hiding this comment.
wciąż nie wiem jak to testować pnpm'em (npm działa) 😅 ale poszedł fix
Member
There was a problem hiding this comment.
wciąż nie wiem jak to testować pnpm'em (npm działa) 😅 ale poszedł fix
Member
Author
There was a problem hiding this comment.
Dobra, doczytałem. Cały czas używałem pnpx i ponoć on zawsze pobiera z https://registry.npmjs.org/ najnowszą wersję a pnpm exec bierze z lokalnego link'a 😅
kguzek
requested changes
May 12, 2026
kguzek
requested changes
May 12, 2026
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: ${pnpmVersion}`; | ||
| version: ${pnpmVersion}\n`; |
Member
There was a problem hiding this comment.
mega nitpick ale w innych plikach templatów ci nie używamy \n tylko dosłownie wstawiamy newline 😭
Suggested change
| version: ${pnpmVersion}\n`; | |
| version: ${pnpmVersion} | |
| `; |
(możesz kliknąć apply suggestion)
kguzek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inicjalizuje setup pnpm-a przed setupem node-a