JS-2020 Fix S3735 false positives on voided member calls

[erwan-leforestier-sonarsource]

Summary

This fixes S3735 false positives on untyped member calls such as void this.load(), which currently conflict with @typescript-eslint/no-floating-promises when type information is unavailable.

Changes

• broadened the no-type-info fallback so member calls and optionally chained calls are treated like other voided call expressions
• kept typed member calls precise while failing open only when the resolved call type is indeterminate
• added rule tests for untyped member calls, optional chaining, indeterminate typed calls, and preserved non-promise reports

Functional Validation

Artifact: JS-2020-fv.zip

Once the file is attached to the PR description, unzip and run:
./run.sh

Expected output:

******************* MASTER *******************
Analyzing "sample.jsx"...
Results:
    - Rule "S3735" -> L.10
    - Rule "S3735" -> L.11

****** Branch "fix/js-2020-allow-voided-promise-calls" ******
Analyzing "sample.jsx"...
Results:
    - Rule "S3735" -> L.11

⚠️⚠️ This is not ready for review ⚠️⚠️

[hashicorp-vault-sonar-prod]

JS-2020

[github-actions]

Ruling Report

Code no longer flagged (2 issues)

S3735

eigen/src/palette/organisms/screenStructure/Screen.tsx:74

    72 | 
    73 |   useEffect(
>   74 |     () => void setOptions({ handleTopSafeArea: header === "none" || header === "floating" }),
    75 |     [header]
    76 |   )

eigen/src/palette/organisms/screenStructure/Screen.tsx:234

   232 |       left={0}
   233 |       right={0}
>  234 |       onLayout={(evt) => void setOptions({ bottomViewHeight: evt.nativeEvent.layout.height })}
   235 |     >
   236 |       <LinearGradient

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Broadens the S3735 no-type-info fallback to correctly handle untyped member calls and optional chaining. Ensure the JSDoc for hasIndeterminateType is updated to accurately reflect the check for unresolved error types.

✅ 1 resolved

✅ Quality: JSDoc mentions error type not explicitly handled

📄 packages/analysis/src/jsts/rules/S3735/rule.ts:95-104
The JSDoc for hasIndeterminateType states it returns true for any, unknown, or "an unresolved error type", but the implementation only checks ts.TypeFlags.Any | ts.TypeFlags.Unknown. There is no explicit branch for an error type. In practice this still works because TypeScript's error type carries the Any flag, so it is caught by the Any check — but the documentation implies a dedicated check that does not exist. Consider either removing the "unresolved error type" phrasing from the doc comment or adding a short note that error types are covered implicitly via the Any flag, to avoid future confusion for maintainers.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube