ECHOES-1356 Add announcement modes to MessageCallout and MessageInline#701
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0e1d1c3 to
5987727
Compare
5987727 to
320466b
Compare
320466b to
9cad103
Compare
9cad103 to
0a0b02f
Compare
gregaubert
left a comment
There was a problem hiding this comment.
Looks good!
It might be worth adding the MessageInline and MessageCallout typescript documentation since we are touching these components.
465d604 to
2ea6db5
Compare
0a0b02f to
f67ba13
Compare
f67ba13 to
6a89b75
Compare
|
87a0947
into
ECHOES-1341-add-alert-and-status-announcement-modes-to-banner
Code Review ✅ Approved 1 resolved / 1 findingsIntegrates ✅ 1 resolved✅ Edge Case: Live-region announcement may not fire when rendered with content
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |



Summary by Gitar
announcementModeprop toMessageCalloutandMessageInlineto enablealertorstatuslive-region semantics.LiveRegionAnnouncementModeinto both components to manage ARIA roles dynamically.announcementModecontrols and examples.ARIA-labeldescription for theMessageCalloutdismiss button ini18n/keys.jsonand component code.This will update automatically on new commits.