Skip to content

ECHOES-1409 Update spinner default styling#713

Merged
david-cho-lerat-sonarsource merged 4 commits into
mainfrom
fix/ECHOES-1409-spinner-default-inverse
Jul 3, 2026
Merged

ECHOES-1409 Update spinner default styling#713
david-cho-lerat-sonarsource merged 4 commits into
mainfrom
fix/ECHOES-1409-spinner-default-inverse

Conversation

@marciopmoreira6

Copy link
Copy Markdown
Contributor

Summary

  • update Spinner default arc color to inverse
  • render the weak track as a fixed solid border
  • preserve spinner arc color overrides via --spinner-color-override
  • add style regression tests for the default arc, override path, and fixed weak track

Tests

  • yarn jest src/components/spinner/tests/Spinner-test.tsx src/components/buttons/tests/Button-test.tsx src/components/buttons/tests/ButtonIcon-test.tsx src/components/badges/tests/BadgeSeverity-test.tsx
  • yarn lint
  • yarn prettier --check src/components/spinner/SpinnerStyles.tsx src/components/spinner/SpinnerOverrideColor.tsx src/components/spinner/tests/Spinner-test.tsx

Jira: https://sonarsource.atlassian.net/browse/ECHOES-1409

@netlify

netlify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit d304f49
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a476af13c27a10008ee2e82
😎 Deploy Preview https://deploy-preview-713--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 2, 2026

Copy link
Copy Markdown

ECHOES-1409

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqube-next

sonarqube-next Bot commented Jul 3, 2026

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👍

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource merged commit e2f168b into main Jul 3, 2026
12 checks passed
@david-cho-lerat-sonarsource david-cho-lerat-sonarsource deleted the fix/ECHOES-1409-spinner-default-inverse branch July 3, 2026 08:45
@gitar-bot

gitar-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates the spinner default arc color to inverse and standardizes the weak track rendering. Style regression tests were added to ensure consistent behavior across overrides and components, with no issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants