SONARJAVA-6114 Provide GitHub token with RSpec access to rule-api.jar#5470
Conversation
tomasz-tylenda-sonarsource
changed the title
|
asya-vorobeva
left a comment
asya-vorobeva
left a comment
There was a problem hiding this comment.
LGTM apart from commented command
| GITHUB_TOKEN: ${{ fromJSON(steps.secrets.outputs.vault).GITHUB_TOKEN_RSPEC }} | ||
| run: | | ||
| java -jar "/tmp/rule-api.jar" update | ||
| sed --in-place='' -e 's/rule:java:S3649/rule:javasecurity:S3649/g' 'sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S2077.html' |
There was a problem hiding this comment.
Do we really need to store this replacement as a regular thing? Probably it should be removed?
There was a problem hiding this comment.
I verified locally that this sed command is still applicable.
I just ran rule-api update and it did change S2077.html. While I am not aware of the context, our release instructions ("Release sonar-java" on the xtranet) very specifically say "Warning: Make sure we not replace {rule:javasecurity:S3649} by {rule:java:S3649}."
There was a problem hiding this comment.
Ok, I see the problem, it's related to lack of configuration in sonar-rule-api repository when generating templates for rules. Probably it makes sense to create a task to fix such cases (for CFamily squad).
tomasz-tylenda-sonarsource
deleted the
tt/update-rule-metadata-rspec-fix
branch
2 participants
No description provided.