Skip to content

CLP-141 Clean up Renovate config in sonar-java#5759

Merged
pavel-mikula-sonarsource merged 1 commit into
masterfrom
vdiez/renovate-cleanup-parent-20260708
Jul 8, 2026
Merged

CLP-141 Clean up Renovate config in sonar-java#5759
pavel-mikula-sonarsource merged 1 commit into
masterfrom
vdiez/renovate-cleanup-parent-20260708

Conversation

@vdiez

@vdiez vdiez commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Part of CLP-11.

This PR cleans up the local Renovate config after the latest updates in the squad parent preset.

Expected current effective delta:

  • track mise.toml updates

@vdiez vdiez requested a review from a team July 8, 2026 07:36
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Clean up Renovate config in sonar-java CLP-141 Clean up Renovate config in sonar-java Jul 8, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

CLP-141

@gitar-bot

gitar-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Code Review ⚠️ Changes requested 0 resolved / 1 findings

Removes Renovate configuration overrides to align with squad parent presets, but removing enabledManagers risks unexpectedly enabling the mise manager.

⚠️ Bug: Removing enabledManagers may newly enable the mise manager

📄 renovate.json5

The PR removes the enabledManagers list (maven, gradle, gradle-wrapper, github-actions) with the justification that "the managers it excluded do not match any files in this repo," and states the expected effective delta is none.

However, this repo contains a mise.toml at the root ([tools] java = ["26","21","17"], maven = "3.9"). Renovate ships a mise manager that is enabled by default and matches mise.toml. Previously the enabledManagers allow-list restricted Renovate to only the four listed managers, so mise was excluded. After this change, unless the parent preset (local>SonarSource/core-languages-tooling-public:renovate-config) re-restricts enabledManagers, Renovate will begin picking up mise.toml and may open new PRs to bump the pinned Java/Maven tool versions — contradicting the "delta: none" expectation.

Please confirm whether the parent preset sets enabledManagers (or otherwise disables the mise manager). If it does not, either keep the enabledManagers allow-list or explicitly disable the mise manager to preserve current behavior.

🤖 Prompt for agents
Code Review: Removes Renovate configuration overrides to align with squad parent presets, but removing enabledManagers risks unexpectedly enabling the mise manager.

1. ⚠️ Bug: Removing enabledManagers may newly enable the mise manager
   Files: renovate.json5

   The PR removes the `enabledManagers` list (`maven`, `gradle`, `gradle-wrapper`, `github-actions`) with the justification that "the managers it excluded do not match any files in this repo," and states the expected effective delta is none.
   
   However, this repo contains a `mise.toml` at the root (`[tools] java = ["26","21","17"]`, `maven = "3.9"`). Renovate ships a `mise` manager that is enabled by default and matches `mise.toml`. Previously the `enabledManagers` allow-list restricted Renovate to only the four listed managers, so `mise` was excluded. After this change, unless the parent preset (`local>SonarSource/core-languages-tooling-public:renovate-config`) re-restricts `enabledManagers`, Renovate will begin picking up `mise.toml` and may open new PRs to bump the pinned Java/Maven tool versions — contradicting the "delta: none" expectation.
   
   Please confirm whether the parent preset sets `enabledManagers` (or otherwise disables the `mise` manager). If it does not, either keep the `enabledManagers` allow-list or explicitly disable the `mise` manager to preserve current behavior.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change the behavior for this request:

Auto-apply Compact Unblock
gitar auto-apply:on         
gitar display:verbose         
gitar unblock         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

sonarqube-next Bot commented Jul 8, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit e3ac0a1 into master Jul 8, 2026
18 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the vdiez/renovate-cleanup-parent-20260708 branch July 8, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants