You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes Renovate configuration overrides to align with squad parent presets, but removing enabledManagers risks unexpectedly enabling the mise manager.
⚠️Bug: Removing enabledManagers may newly enable the mise manager
The PR removes the enabledManagers list (maven, gradle, gradle-wrapper, github-actions) with the justification that "the managers it excluded do not match any files in this repo," and states the expected effective delta is none.
However, this repo contains a mise.toml at the root ([tools] java = ["26","21","17"], maven = "3.9"). Renovate ships a mise manager that is enabled by default and matches mise.toml. Previously the enabledManagers allow-list restricted Renovate to only the four listed managers, so mise was excluded. After this change, unless the parent preset (local>SonarSource/core-languages-tooling-public:renovate-config) re-restricts enabledManagers, Renovate will begin picking up mise.toml and may open new PRs to bump the pinned Java/Maven tool versions — contradicting the "delta: none" expectation.
Please confirm whether the parent preset sets enabledManagers (or otherwise disables the mise manager). If it does not, either keep the enabledManagers allow-list or explicitly disable the mise manager to preserve current behavior.
🤖 Prompt for agents
Code Review: Removes Renovate configuration overrides to align with squad parent presets, but removing enabledManagers risks unexpectedly enabling the mise manager.
1. ⚠️ Bug: Removing enabledManagers may newly enable the mise manager
Files: renovate.json5
The PR removes the `enabledManagers` list (`maven`, `gradle`, `gradle-wrapper`, `github-actions`) with the justification that "the managers it excluded do not match any files in this repo," and states the expected effective delta is none.
However, this repo contains a `mise.toml` at the root (`[tools] java = ["26","21","17"]`, `maven = "3.9"`). Renovate ships a `mise` manager that is enabled by default and matches `mise.toml`. Previously the `enabledManagers` allow-list restricted Renovate to only the four listed managers, so `mise` was excluded. After this change, unless the parent preset (`local>SonarSource/core-languages-tooling-public:renovate-config`) re-restricts `enabledManagers`, Renovate will begin picking up `mise.toml` and may open new PRs to bump the pinned Java/Maven tool versions — contradicting the "delta: none" expectation.
Please confirm whether the parent preset sets `enabledManagers` (or otherwise disables the `mise` manager). If it does not, either keep the `enabledManagers` allow-list or explicitly disable the `mise` manager to preserve current behavior.
Options
Auto-apply is off → Gitar will not commit updates to this branch. Display: compact → Showing less information. Unblock → Override a blocking verdict and allow merging.
Comment with these commands to change the behavior for this request:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CLP-11.
This PR cleans up the local Renovate config after the latest updates in the squad parent preset.
Expected current effective delta:
mise.tomlupdates