Skip to content

Refactor/remove backtick query builder#407

Merged
SonyPradana merged 5 commits into
masterfrom
refactor/remove-backtick-query-builder
Jan 1, 2025
Merged

Refactor/remove backtick query builder#407
SonyPradana merged 5 commits into
masterfrom
refactor/remove-backtick-query-builder

Conversation

@SonyPradana

@SonyPradana SonyPradana commented Dec 31, 2024

Copy link
Copy Markdown
Owner
Q A
Is bugfix? Yes
New feature? No
Breaks BC? No
Fixed issues comma-separated list of tickets # fixed by the PR, if any

Remove backtick in query builder. sometimes column wrap with backtick, we recommended add manually to prevent alias wrap not perfectly.

address of #404

@SonyPradana SonyPradana left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve this as soon as possible

Comment thread src/System/Database/MyModel/Model.php Outdated
Comment thread src/System/Database/MyModel/Model.php Outdated
Comment thread src/System/Database/MyQuery/InnerQuery.php Outdated
Comment thread src/System/Database/MyQuery/Query.php Outdated
Comment thread src/System/Database/MyQuery/Select.php Outdated
Comment thread src/System/Database/MyQuery/Select.php Outdated
Comment thread src/System/Database/MyQuery/Traits/ConditionTrait.php Outdated
Comment thread src/System/Database/MyQuery/Update.php Outdated
Comment thread src/System/Database/MySchema/Table/Create.php Outdated
Comment thread src/System/Database/MySchema/Table/Create.php Outdated
@SonyPradana SonyPradana merged commit 1508483 into master Jan 1, 2025
@SonyPradana SonyPradana deleted the refactor/remove-backtick-query-builder branch January 1, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants