Skip to content

fix: shorten ContractEvent index names and fix ruff lint (unblocks #819)#820

Open
Abd-Standard wants to merge 2 commits into
SoroScan:mainfrom
Abd-Standard:fix/ci-index-names-lint
Open

fix: shorten ContractEvent index names and fix ruff lint (unblocks #819)#820
Abd-Standard wants to merge 2 commits into
SoroScan:mainfrom
Abd-Standard:fix/ci-index-names-lint

Conversation

@Abd-Standard

Copy link
Copy Markdown

Problem

PR #819 introduced 3 CI failures:

  1. Load Tests / Pact TestsStart API server exited 1 because manage.py migrate aborted on Django system check models.E034: index names exceeded the 30-character limit.

    • ingest_contractevent_contract_timestamp_desc_idx = 49 chars ❌
    • ingest_contractevent_timestamp_desc_idx = 40 chars ❌
  2. Django Backend CIruff check failed (F401 unused imports AsyncMock, call; F841 unused variable result in test_graphql_logging.py).

Fix

  • Rename both indexes in models.py and migration 0046 to ≤30 chars
  • Remove unused symbols from test_graphql_logging.py

Closes #819 CI failures.

- ingest_contractevent_contract_timestamp_desc_idx (49) → ingest_ce_cont_ts_desc_idx (26)
- ingest_contractevent_timestamp_desc_idx (40) → ingest_ce_ts_desc_idx (21)
- Fixes models.E034 Django system check that broke migrate in CI
- Remove unused AsyncMock, call imports and result variable (ruff F401/F841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant