feat: issue-93/94#161
Open
OSEH-svg wants to merge 2 commits into
Open
Conversation
|
@OSEH-svg Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@k-deejah please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #93
closes #94
PR Summary
This PR resolves two related issues by fixing responsive behavior in the dashboard UI and completing the library public export surface.
What changed
Responsive fixes (Issue #94)
src/screens/Dashboard.tsxto prevent the main content area from collapsing on short viewports by addingmin-h-0to the flex child container.src/components/TopBar.tsxto prevent header overflow at 320px by allowing the right-side controls to wrap, keepingNetworkSwitcherandWalletConnectButtonusable on narrow mobile screens.src/components/TransactionHistory.tsxto ensure pagination buttons meet the 44px touch target minimum on mobile by applyingmin-h-[44px]to the button controls.Export API fixes (Issue #93)
src/components/index.ts:AddressDisplayAssetPillFeeEstimatorContractEventFeedsrc/lib/client.tsthrough the public API:AccountDataBalanceTransactionClaimableBalanceContractEventNetworkInfoInvokeParamssrc/__tests__/exports.test.tsverifying the public exports surface and the re-exported types.Why these changes were needed
flex-1to collapse on shorter devices such as landscape mobile.TopBarheader overflowed at the narrowest common mobile viewport because the controls did not wrap.sorokit-ui.Verification
Files changed
src/screens/Dashboard.tsxsrc/components/TopBar.tsxsrc/components/TransactionHistory.tsxsrc/components/index.tssrc/__tests__/exports.test.ts