Fix/accessibility and mock issues#162
Open
Jess52487 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #100
closes #101
closes #102
Description
This PR resolves three groups of issues related to UI accessibility, connection UX, and test reliability:
1. Badge Accessibility
Badgecomponent from9pxto11pxto meet WCAG minimum readable size.liveboolean prop to dynamically updated badges. When true, it appliesrole="status"andaria-live="polite", ensuring screen readers announce status changes (e.g., transaction outcomes).aria-hidden="true"to the decorative pulsing dot, preventing it from being announced incorrectly.2. Wallet Connection UX
errorstate fromSorokitProviderto render an inline error banner on theConnectScreen.clearError().alt="sorokit wallet dashboard preview"attribute for the hero image to improve screen reader context.3. Mock Client Reliability
{ data: null, error: "Unknown network..." }response, rather than failing silently to testnet.MOCK_HISTORYandMOCK_EVENTSto use a deterministic mock generation algorithm rather than module-load-timerandHex()calls, ensuring snapshot tests pass consistently across test runs.Acceptance Criteria met
text-[11px]<Badge live>hasrole="status"andaria-live="polite"aria-hidden="true"errorrenders onConnectScreenas an inline banner with dismiss functionalityaltattributeMOCK_ADDRESSpasses format check andswitchNetworkhandles invalid strings properlyMOCK_HISTORYandMOCK_EVENTSare deterministicnpm run buildandnpm run lintpass successfully