fix(wallet): resolve mock addresses, extract client adapter, and impl…#164
Open
Luchi5544 wants to merge 2 commits into
Open
fix(wallet): resolve mock addresses, extract client adapter, and impl…#164Luchi5544 wants to merge 2 commits into
Luchi5544 wants to merge 2 commits into
Conversation
…ement soroban methods
|
@Luchi5544 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #99
Description
This PR addresses the issues with the mocked wallet address, TODO stubs, and the inline 200-line client adapter in
src/main.tsx.Changes
@creit.tech/stellar-wallets-kitto replace the hardcoded "GBAMQXTQ..." mock address. The "Connect Wallet" button now launches a real wallet picker modal and returns the user's actual connected public key.TODOstubs that returned{ error: "Not implemented" }forinvokeContractandgetEvents. It now properly delegates to the actualcoreClient.soroban.invokeContractandcoreClient.soroban.getEventsimplementations.src/main.tsxinto its own designated modulesrc/lib/adapter.ts. Ensured proper typings by implementing theLocalSorokitClientinterface and using strongly typedInvokeParamswithout any inlineanybypasses.Acceptance Criteria Met
soroban.invokeContractno longer returns{ error: "Not implemented" }createClientAdapterlives insrc/lib/adapter.tswith noanytypesnpm run buildandtsc --noEmitpassTesting
tsc --noEmitcompilation locally.