fix: prevent race conditions and add retry for fee estimator#166
Open
dinahmaccodes wants to merge 5 commits into
Open
fix: prevent race conditions and add retry for fee estimator#166dinahmaccodes wants to merge 5 commits into
dinahmaccodes wants to merge 5 commits into
Conversation
|
@dinahmaccodes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR addresses four UI component issues related to race conditions, accessibility, and visual consistency.
Changes Made
Issue #89 - FeeEstimator: Race Conditions & Error Recovery
loadingRefto prevent concurrentload()calls from racingload()from error stateIssue #90 - AssetBadge: Color Variety & Export
AssetPillfromsrc/components/index.tsfor library consumersIssue #91 - SorobanInvokeButton: Double-Click Guard & Error Handling
isInvokingRefguard to prevent concurrent invocations on double-clickdisabled={!isConnected || state === "loading"}to block rapid clicksfriendlyError()utility to map raw Horizon/Soroban errors to user-friendly messagesaria-label="Reset invocation result"to Reset button for accessibilityIssue #92 - Button: Accessibility Improvements
aria-busy={loading || undefined}during loading stateasChildmode to block clicks when disabled/loadingpreventDefault()andstopPropagation()Testing
npm run buildpassesnpm run lintpasses (for modified components)Checklist
Closes #89
Closes #90
Closes #91
Closes #92