Feat/issues 185 195 84 206#222
Open
caxtonacollins wants to merge 8 commits into
Open
Conversation
…labels and timeout - Add requireConfirm, confirmLabel, and confirmTimeout props to Button component - First click shows confirmLabel, second click fires onClick - Timeout resets to original label after configurable delay (default 3s) - Add comprehensive tests covering all confirmation scenarios - Includes cleanup for timeout on component unmount Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Implement full FeeEstimator component with fee estimation from client - Show base fee and recommended fee with XLM conversion (stroops / 10_000_000) - Display 'High fee' badge when recommended > 2x base fee - Add live region for accessibility and auto-refresh every 10 seconds - Add comprehensive tests for XLM conversion and high-fee badge logic Closes Sorokit#185 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…py functionality - Add tests for network info cells with copyable passphrase and RPC URL - Add tests for QR code display when connected and receive funds section - Add tests for copy button functionality with navigator.clipboard - Ensure proper UX for connected and disconnected states Closes Sorokit#185 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add isLoading state that aggregates isConnecting and isLoadingAccount - Fix Promise.all error handling to keep first non-null error instead of overwriting - Ensure refreshAccount properly updates isLoadingAccount during refresh - Add error state reset on new requests Closes Sorokit#195 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…handling - Add cancelled flag cleanup to prevent stale balance updates on address change - Reset error state at the beginning of fetch to clear previous errors - Ensure cleanup function runs before setting balances to prevent race conditions - Already had proper error feedback in BalanceRow component Closes Sorokit#84 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Update to a valid version of the stellar-wallets-kit package that exists in npm registry. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add @testing-library/react and @testing-library/user-event for component testing - Add @radix-ui/react-slot, @hugeicons/react, clsx, and tailwind-merge for UI - These dependencies are required by the components and tests Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Use clsx ^1.2.0 instead of ^2.0.0 to match what's available in the dependency tree. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
@caxtonacollins Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four code quality and test coverage issues in the sorokit-ui component library:
#185: Test Coverage - Button requireConfirm, WalletScreen, and FeeEstimator
#195: SorokitProvider - Loading States & Error Handling
isLoadingstate aggregatingisConnectingandisLoadingAccountrefreshAccountupdatesisLoadingAccountproperly#84: ClaimableBalanceCard - Silent Errors & Stale Fetches
cancelledflag to prevent race conditions on address change#206: Code Quality
cn()function correctlyTest Plan
Closes #185
Closes #195
Closes #84
Closes #206