Add coverage gate to hooks and CI#1084
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Run FoundationUI tests with coverage | ||
| run: swift test --package-path FoundationUI --enable-code-coverage 2>&1 | tee Documentation/Quality/foundationui-coverage-test.log | ||
|
|
||
| - name: Enforce coverage threshold (67%) | ||
| run: | |
There was a problem hiding this comment.
Coverage gate skipped for FoundationUI-only changes
The new coverage-gate job runs FoundationUI tests and enforces the 67% threshold, but the workflow’s path filters at the top of this file still omit FoundationUI/**. GitHub Actions won’t trigger the workflow at all when a PR only touches the FoundationUI package, so this gate never executes for the module it is intended to protect and those changes can merge without coverage enforcement. Please add the FoundationUI paths to the workflow triggers (or a dedicated workflow) so the gate actually runs for FoundationUI edits.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task