Skip to content

Add coverage gate to hooks and CI#1084

Merged
SoundBlaster merged 2 commits into
mainfrom
codex/follow-instructions-from-start.md
Dec 10, 2025
Merged

Add coverage gate to hooks and CI#1084
SoundBlaster merged 2 commits into
mainfrom
codex/follow-instructions-from-start.md

Conversation

@SoundBlaster

Copy link
Copy Markdown
Owner

Summary

  • add a macOS-only FoundationUI coverage check to the pre-push hook, running tests with coverage and enforcing the 0.67 threshold via coverage_analysis.py
  • create a macOS coverage-gate GitHub Actions job that mirrors the local gate and uploads coverage logs/reports from Documentation/Quality
  • update task trackers and in-progress notes to record completion of Task A8 and the new coverage artifacts

Testing

  • swift test --package-path FoundationUI --enable-code-coverage (fails on Linux due to missing SwiftUI SDK; gate runs on macOS)

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
Comment on lines +199 to +203
- name: Run FoundationUI tests with coverage
run: swift test --package-path FoundationUI --enable-code-coverage 2>&1 | tee Documentation/Quality/foundationui-coverage-test.log

- name: Enforce coverage threshold (67%)
run: |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Coverage gate skipped for FoundationUI-only changes

The new coverage-gate job runs FoundationUI tests and enforces the 67% threshold, but the workflow’s path filters at the top of this file still omit FoundationUI/**. GitHub Actions won’t trigger the workflow at all when a PR only touches the FoundationUI package, so this gate never executes for the module it is intended to protect and those changes can merge without coverage enforcement. Please add the FoundationUI paths to the workflow triggers (or a dedicated workflow) so the gate actually runs for FoundationUI edits.

Useful? React with 👍 / 👎.

@SoundBlaster SoundBlaster merged commit 7318e4c into main Dec 10, 2025
14 checks passed
@SoundBlaster SoundBlaster deleted the codex/follow-instructions-from-start.md branch December 10, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant