Add moon reference system - #59
Conversation
…action pipeline for this branch
| neptune%output%input_type == INPUT_OSCULATING_MCRF) then | ||
| r_moon_chk = neptune%solarsystem_model%getBodyPosition(epochs(1)%mjd, ID_MOON) | ||
| if(hasFailed()) return | ||
| if(mag(state_in%r - r_moon_chk) < getMoonRadius()) then |
There was a problem hiding this comment.
@ckebschull theoretically we could be hitting the moon even if we have defined the input in a non Moon Centered Frame. I see two options:
- We alwas do this check, which would require to always load the Moon Ephemeris
- We do this check only when the Moon Harmonics model is enabled, as in other cases we are treating it as a point mass.
There was a problem hiding this comment.
@oscarrdfz - addressed it with option 2
| end do | ||
|
|
||
| do i = 1, idimcov-1 | ||
| do i = 1, idimcov-2 |
There was a problem hiding this comment.
I have this comment for the libslam repo @ckebschull -> what is the reason from changing idimcov from 6 to 7?
There was a problem hiding this comment.
@oscarrdfz - this I had to fix to get neptune to run in the latest branch. I guess due to changes made from @danlueck for the Cd propagation.
There was a problem hiding this comment.
I may be wrong but I don't think the changes to the Cd covariance propagation were ever merged
There was a problem hiding this comment.
@ckebschull that was my idea, I would actually advise to not change that yet, have the feeling could break too many other things
There was a problem hiding this comment.
Reverted to 6-dim covariance
…ons are switched on
|
@ckebschull I think we need to at least extend tests/test_thirdbody.pf to include tests with lunar gravity for CI |
|
4 participants
NEPTUNE 1.2.0 Changelog (02-Jun-2026)