Skip to content

🛡️ Sentinel: Fix integer overflow in TokenBucketLimiter#11

Draft
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-fix-overflow-9149623540971139298
Draft

🛡️ Sentinel: Fix integer overflow in TokenBucketLimiter#11
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-fix-overflow-9149623540971139298

Conversation

@google-labs-jules

Copy link
Copy Markdown

🛡️ Sentinel: [CRITICAL] Fix integer overflow in TokenBucketLimiter

Vulnerability: The refill logic calculated tokens to add using periodsElapsed * refillTokens. This multiplication could overflow long if the time elapsed was large enough (e.g., due to system time jump or extreme configuration), resulting in a negative number. This caused the refill logic to abort, leaving the bucket empty indefinitely (DoS).

Fix: Added a pre-check: if (periodsElapsed > capacity / refillTokens). If true, we skip multiplication and simply fill the bucket to capacity, preventing the overflow.

Verification: Added TokenBucketOverflowTest which simulates a massive time jump via reflection and asserts that the bucket correctly refills instead of failing. Verified with ./gradlew test.


PR created automatically by Jules for task 9149623540971139298 started by @SpaceLeam

Fixed a vulnerability where `periodsElapsed * refillTokens` could overflow to a negative number if the time elapsed was very large (or configured with extreme values), effectively causing a Denial of Service by stopping refills. Added a check to clamp the result to capacity if it would overflow.

Added a reproduction test case `TokenBucketOverflowTest` verifying the fix.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants