🛡️ Sentinel: [CRITICAL] Fix integer overflow in rate limiter#13
🛡️ Sentinel: [CRITICAL] Fix integer overflow in rate limiter#13google-labs-jules[bot] wants to merge 1 commit into
Conversation
🚨 Severity: CRITICAL 💡 Vulnerability: Integer overflow in token refill calculation caused potential Denial of Service (bucket locked) or incorrect token counts. 🎯 Impact: High traffic or long idle periods could cause the rate limiter to stop refilling tokens, blocking valid requests. 🔧 Fix: - Added overflow checks for `periodsElapsed * refillTokens`. - Used `long` arithmetic for token accumulation and clamped to `capacity`. ✅ Verification: Added `OverflowTest.java` to reproduce and verify the fix using `Integer.MAX_VALUE` scenarios.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes potential integer overflow in
TokenBucketLimiterwhen calculating refills or adding tokens.Previously,
periodsElapsed * refillTokenscould overflowlonginto negative values, preventing refill.Also,
current + tokensToAddcould overflowintif capacity was nearInteger.MAX_VALUE.The fix ensures:
periodsElapsed * refillTokensis saturated tocapacityif it would overflow.longmath and clamps tocapacitybefore casting toint.Verified with new tests in
OverflowTest.java.PR created automatically by Jules for task 10260658457173210003 started by @SpaceLeam