🛡️ Sentinel: [CRITICAL] Fix integer overflow in rate limiter refill#4
🛡️ Sentinel: [CRITICAL] Fix integer overflow in rate limiter refill#4google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Prevent `periodsElapsed * refillTokens` from overflowing `long` by checking against capacity. - Prevent `current + tokensToAdd` from overflowing `int` by using `long` arithmetic before clamping. - Ensure robust handling of large time gaps and high refill rates.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Identified and fixed integer overflow vulnerabilities in
TokenBucketLimiter.periodsElapsed * refillTokensto overflowlong, resulting in negative values. Added a check to captokensToAddatcapacityif the calculated periods are sufficient to fill the bucket.tokensToAddtocurrenttokens could overflowintif both were nearInteger.MAX_VALUE. Changed the update logic to perform the addition aslongand clamp the result usingMath.minbefore casting back toint.These changes prevent potential Denial of Service or logic errors where valid requests might be rejected or tokens incorrectly calculated. verified with new test cases covering these edge scenarios.
PR created automatically by Jules for task 7994293176795885305 started by @SpaceLeam