Sentinel: Fix integer overflow in token refill logic#6
Sentinel: Fix integer overflow in token refill logic#6google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Prevent integer overflow when calculating refill tokens after long periods of inactivity - Optimize `refill()` to use manual `compareAndSet` loop instead of `updateAndGet` - Add regression test `TokenBucketOverflowTest` - Add security journal entry
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixed an integer overflow vulnerability in
TokenBucketLimiterwhereperiodsElapsed * refillTokenscould overflowlong(or result in incorrect values) when the limiter was idle for a long time or configured with high refill rates. This could lead to incorrect token counts or failure to refill. Also optimized the refill loop to reduce object allocation.PR created automatically by Jules for task 17402866809208906977 started by @SpaceLeam