🛡️ Sentinel: Fix integer overflow in token refill calculation#9
🛡️ Sentinel: Fix integer overflow in token refill calculation#9google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Prevents integer overflow when calculating refill tokens after a long pause with high refill rate. - Adds optimization to skip calculation if periods elapsed exceeds capacity. - Adds `OverflowTest.java` to verify the fix and prevent regression.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes a potential integer overflow in
TokenBucketLimiterwhereperiodsElapsed * refillTokenscould overflowlongand become negative, preventing the bucket from refilling. Added a reproduction test case.PR created automatically by Jules for task 5190783549830991923 started by @SpaceLeam