Merged
Conversation
The error had format w/o argument. The `error` variable was unused.
|
Got that from the AUR package on Arch along some warnings: |
Contributor
Author
Contributor
Author
|
Probably caused by this: |
Contributor
|
Welp, that’s incredibly embarrassing ;-; Sorry for the build error :c Adding ‘learn how pre-commit works’ to my todo |
acuteaangle
added a commit
to acuteaangle/pineflash
that referenced
this pull request
Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
acuteaangle
added a commit
to acuteaangle/pineflash
that referenced
this pull request
Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
Contributor
Author
|
@Spagett1 ping |
|
Confirmed this fixes the problems with building on macOS. |
Owner
|
Thank you for the patch, I was unaware of master failing to build, appreciate the help and sorry for the delay in merging. |
Contributor
Author
Thanks. Btw, there is PR #88 that should prevent this type of mistake in the future |
acuteaangle
added a commit
to acuteaangle/pineflash
that referenced
this pull request
Mar 23, 2025
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error had format w/o argument. The
errorvariable was unused.