Skip to content

fix: Fix for test_action_recommender.py #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonidb merged 2 commits into from
Jan 13, 2026
Merged

fix: Fix for test_action_recommender.py #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247188d
fix: Fix for test_action_recommender.py
ErikLagerSB Dec 15, 2025
ef77147
fix comments
ErikLagerSB Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/agentune/improve/recommend/test_action_recommender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,11 @@ async def test_action_recommender(
pytest.skip('No conversation features found')

assert isinstance(report, RecommendationsReport)
assert len(report.recommendations) > 0

if len(report.recommendations) == 0:
logger.error('All recommendations were filtered out due to lack of valid supporting features (R² = 0)')
logger.error(f'Raw report: {report.raw_report}')
pytest.fail('No recommendations generated - all were filtered out due to lack of valid supporting features')

# Optionally save results (useful for manual inspection)
save_results = os.getenv('SAVE_TEST_RESULTS', 'false').lower() == 'true'
Expand Down Expand Up @@ -433,7 +437,11 @@ async def test_action_recommender_with_long_conversations_token_sampling(
# Verify that the recommender still produced valid results
assert isinstance(report, RecommendationsReport)
assert len(report.analysis_summary) > 50
assert len(report.recommendations) > 0

if len(report.recommendations) == 0:
Copy link
Collaborator

@leonidb leonidb Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

logger.error('All recommendations were filtered out due to lack of valid supporting features (R² = 0)')
logger.error(f'Raw report: {report.raw_report}')
pytest.fail('No recommendations generated - all were filtered out due to lack of valid supporting features')

# Check that some conversations were included but not all
# The raw_report should contain some conversation content but not all conversations
Expand Down