Skip to content

Clean up comments related to traces#1678

Merged
rowleya merged 3 commits into
SpiNNakerManchester:masterfrom
clinssen:trace_comments_cleanup
Jul 21, 2026
Merged

Clean up comments related to traces#1678
rowleya merged 3 commits into
SpiNNakerManchester:masterfrom
clinssen:trace_comments_cleanup

Conversation

@clinssen

@clinssen clinssen commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Tiny cleanup of the naming and comments related to synaptic traces. (I believe "o1" and "o2" are related to triplet STDP rules, that's probably where this came from.)

@clinssen
clinssen force-pushed the trace_comments_cleanup branch from 3c3c254 to 8848557 Compare July 7, 2026 10:22
@clinssen
clinssen force-pushed the trace_comments_cleanup branch from 8848557 to 722d23c Compare July 7, 2026 11:20
@rowleya

rowleya commented Jul 9, 2026

Copy link
Copy Markdown
Member

Please add "pull_request" to the list here:
https://github.com/clinssen/sPyNNaker/blob/trace_comments_cleanup/.github/workflows/python_actions.yml#L23
and here:
https://github.com/clinssen/sPyNNaker/blob/trace_comments_cleanup/.github/workflows/c_actions.yml#L19

This will then make the tests run on our side and let me merge things directly.

@rowleya rowleya self-assigned this Jul 21, 2026
@rowleya
rowleya merged commit 5e05488 into SpiNNakerManchester:master Jul 21, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants