More flexible STDP make#1679
Open
rowleya wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the STDP build flow so timing/weight rule headers are enforced at compile time (instead of make-time), making it easier to support STDP implementations where code is generated/packaged differently (e.g., a single generated file as in NESTML).
Changes:
- Move “missing timing/weight rule” enforcement into
synapse_dynamics_stdp_common.hvia compile-time#errorchecks. - Simplify STDP-related make rules by removing the older
STDP_ENABLED/SYNGEN_ENABLEDgating and building include lists incrementally. - Minor cleanup/normalization (indentation tidy-ups;
make cleanalso removesmodified_srcoutput).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| neural_modelling/src/neuron/plasticity/stdp/synapse_dynamics_stdp_mad_impl.c | Removes redundant post_events.h include (now pulled via common header) and normalizes indentation. |
| neural_modelling/src/neuron/plasticity/stdp/synapse_dynamics_stdp_common.h | Adds explicit compile-time errors if timing/weight rule APIs haven’t been included. |
| neural_modelling/make/synapse_build.mk | Refactors synapse-only build rules to accumulate STDP_INCLUDES/SYNGEN_INCLUDES and simplifies compile macros/clean output. |
| neural_modelling/make/neuron_only_build.mk | Refactors neuron include handling into a file list + pattern expansion; clean also removes modified_src. |
| neural_modelling/make/neural_build.mk | Mirrors the synapse build refactor for full neural builds; simplifies compile macros and clean output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor make process a little to allow other STDP systems which don't need the weight and timing rules to be separately implemented. This is particularly relevant to NESTML where the STDP code is generated in a single file.