Try to make lupin working with threads #4333
Open
+80
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thread_an_no_nogil
for more information, see https://pre-commit.ci
This was referenced Jan 19, 2026
alejoe91
reviewed
Jan 21, 2026
| node0 = nodes[0] | ||
| if isinstance(node0, PeakSource) and node0.need_first_call_before_pipeline: | ||
| # See need_first_call_before_pipeline : this trigger numba compilation before the run | ||
| node0._first_call_before_pipeline() |
Member
There was a problem hiding this comment.
Shouldn't this be a common function (by default pass) for all nodes? I assume any nodes using a numba kernel would benefit from this
Member
Author
There was a problem hiding this comment.
Other nodes are more complicated because we need to run the entire chain.
This help now for peak_detection.
Lets see how we can optimize this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This try to make lupin working with thread.
This will be usefull because on windows the spwan and process parrallel is using too much memory
this replace:
#4331
#4309