Let the user defines if he want to get a warning for filtering wrt margin #4334
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Member
|
I do not like it too much. |
Collaborator
Author
|
Open to any discussions, but I do think such warnings are usefull. I just want a way to avoid them for the analyzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we hard coded a value of MARGIN_TO_CHUNK_PERCENT_WARNING = 0.2 # 20% that pops a warning each time the user is requesting a small chunk compared to the margin.
But this has very annoying side effects when dealing with analyzers. Users providing a filtered signal as an input will have tons of warning messages when extracting waveforms (that are snippets rather small). For now, this PR, at the very least, offer the possibilities for user to create a filtered object that will display marging warnings OR not.
Should it be done automatically in case of an analyzer ? This is an open question here