Feat/angi integration#1
Conversation
| DEV_DB_PASSWORD:projects/${{secrets.GCP_PROJECT_NUMBER}}/secrets/DEV_DB_PASSWORD | ||
| DEV_DB_USER:projects/${{secrets.GCP_PROJECT_NUMBER}}/secrets/DEV_DB_USER | ||
|
|
||
|
|
There was a problem hiding this comment.
What needs to be added here bro? Like I didn't got your message here.
There was a problem hiding this comment.
Cache related variables are not added.
There was a problem hiding this comment.
which are commented below
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY requirements.txt . |
There was a problem hiding this comment.
would recommend COPY . .
instead of COPY for each file.
| @@ -0,0 +1,10 @@ | |||
| .PHONY: test lint format | |||
There was a problem hiding this comment.
is this being used for running pre-commit while building docker image?
There was a problem hiding this comment.
could you please remove if any of the files are not needed?
There was a problem hiding this comment.
file not needed in prod
| DEV_DB_PASSWORD:projects/${{secrets.GCP_PROJECT_NUMBER}}/secrets/DEV_DB_PASSWORD | ||
| DEV_DB_USER:projects/${{secrets.GCP_PROJECT_NUMBER}}/secrets/DEV_DB_USER | ||
|
|
||
|
|
There was a problem hiding this comment.
which are commented below
| @@ -0,0 +1,10 @@ | |||
| .PHONY: test lint format | |||
There was a problem hiding this comment.
could you please remove if any of the files are not needed?
| @@ -0,0 +1,6 @@ | |||
| runtime: python310 | |||
There was a problem hiding this comment.
i think this is not needed. we have deploy.yml already to deploy things.
| @@ -0,0 +1,31 @@ | |||
| services: | |||
There was a problem hiding this comment.
file not needed for prod
There was a problem hiding this comment.
do we have any initial migrations generated? if not, we need to generate them and add it to the code. We cant generate migrations in prod.
| @@ -0,0 +1,37 @@ | |||
| import os | |||
There was a problem hiding this comment.
I think the logic to add environment as suffix is not added. The variable names should be environment independent.
2 participants
No description provided.