Skip to content

Update local dependencies, migrate to JSpecify#352

Merged
alexander-yevsyukov merged 10 commits intomasterfrom
new-core-java
May 9, 2025
Merged

Update local dependencies, migrate to JSpecify#352
alexander-yevsyukov merged 10 commits intomasterfrom
new-core-java

Conversation

@alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented May 8, 2025

This PR migrates ProtoData to latest versions of Base, Validation, CoreJava, and other internal dependencies.

Other notable changes

  • config was pulled brining latest changes to buildSrc.
  • Annotates were migrated to JSpecify.
  • BoundedContextBuilder.add() extension from the io.spine.protodata.plugin package was deprecated in favour of one available from io.spine.server.
  • Usages of (is_required) option were migrated to (choice).required.
  • Console noise was reduced by tapping the output in tests where we emit warnings or errors intentionally.
  • Tests and test fixture proto types that use field references in (min) and (max) options were commented out and disabled until the Validation support is addressed.
  • Fixed logging output in BeforePrimaryDeclaration.

Also:
 * Temporarily comment out `(min)/(max)` options with field references. See: SpineEventEngine/validation#64
... if favour of the one available from CoreJava.
Also:
 * Suppress warning on opened function.
Also:
 * Address the dependency property deprecation.
@alexander-yevsyukov alexander-yevsyukov changed the title Update dependencies Update local dependencies, bump Protobuf Gradle Plugin -> 0.9.5 May 8, 2025
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.85%. Comparing base (9e9db1e) to head (04de1ea).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
- Coverage     74.52%   73.85%   -0.67%     
  Complexity      613      613              
============================================
  Files           197      197              
  Lines          4294     4296       +2     
  Branches        397      397              
============================================
- Hits           3200     3173      -27     
- Misses          965      996      +31     
+ Partials        129      127       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov changed the title Update local dependencies, bump Protobuf Gradle Plugin -> 0.9.5 Update local dependencies May 8, 2025
@alexander-yevsyukov alexander-yevsyukov changed the title Update local dependencies Update local dependencies, migrate to JSpecify May 8, 2025
@alexander-yevsyukov alexander-yevsyukov self-assigned this May 8, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review May 8, 2025 18:43
@alexander-yevsyukov alexander-yevsyukov requested a review from armiol May 8, 2025 18:43
@alexander-yevsyukov alexander-yevsyukov merged commit f6be09a into master May 9, 2025
8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the new-core-java branch May 9, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants