Skip to content

Improve console output#8

Open
Vladyslav-Kuksiuk wants to merge 19 commits intomasterfrom
improve-console-output
Open

Improve console output#8
Vladyslav-Kuksiuk wants to merge 19 commits intomasterfrom
improve-console-output

Conversation

@Vladyslav-Kuksiuk
Copy link
Contributor

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk commented Mar 2, 2026

This PR:

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this Mar 2, 2026
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk marked this pull request as ready for review March 3, 2026 15:51
Copy link

@MykytaPimonovTD MykytaPimonovTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk LGTM with one comment.

@alexander-yevsyukov
Copy link
Contributor

If you format the error using the following pattern, some tools like IntelliJ IDEA would be able to open the file at the given cursor location:

file://my/file/path.md:$line$column

Have a look at the Console class from Spine Compiler for the details on the file URL work.

@dmytro-kashcheiev, FYI.

@alexander-yevsyukov
Copy link
Contributor

Can we improve the console output and have File update: or Files updated: one time and then given the list with the list of file items prefixed with -?

Please also try to avoid the trap with File(s) updated:` message. It makes app look a bit silly. We know the count, we can give the correct language for the count.

@alexander-yevsyukov alexander-yevsyukov self-requested a review March 9, 2026 16:35
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments above.

Copy link
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk LGTM with minor question

Comment on lines +74 to +76
// WithGroup returns a copy of the handler for a new group.
// This handler ignores groups and returns itself.
func (h *Handler) WithGroup(name string) slog.Handler { return h }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure on this? Looks like above in WithAttrs we copy object while here we simply return it maybe we should clone it to match the doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants