Conversation
MykytaPimonovTD
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with one comment.
|
If you format the error using the following pattern, some tools like IntelliJ IDEA would be able to open the file at the given cursor location: Have a look at the @dmytro-kashcheiev, FYI. |
|
Can we improve the console output and have Please also try to avoid the trap with |
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my comments above.
dmytro-kashcheiev
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with minor question
logging/logger.go
Outdated
| // WithGroup returns a copy of the handler for a new group. | ||
| // This handler ignores groups and returns itself. | ||
| func (h *Handler) WithGroup(name string) slog.Handler { return h } |
There was a problem hiding this comment.
Are we sure on this? Looks like above in WithAttrs we copy object while here we simply return it maybe we should clone it to match the doc?
This PR:
Adds new flags for binary execution:
--info— enables theINFOlogging level. Without this flag, theWARNlogging level is used by default.--stacktrace— enables error stack traces. Without this flag, only error messages are shown.Updates console output for successful embedding:
Provides meaningful error messages for fragmentation issues:
#docfragmentor#enddocfragmentprefixes without names:#docfragmentor#enddocfragmentname syntax:Improves error messages for missing code fragments:

Updates binaries and removes developer system info from stack traces:

Resolves:
embed-codetags #4#enddocfragment#5