Add LocalDateValidator and year field ranges#186
Merged
alexander-yevsyukov merged 20 commits intomasterfrom Mar 11, 2026
Merged
Add LocalDateValidator and year field ranges#186alexander-yevsyukov merged 20 commits intomasterfrom
LocalDateValidator and year field ranges#186alexander-yevsyukov merged 20 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 378b90dd96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* Use backticked functions. * Use `run` block for related assertions. * Document why we have `MONTH_UNDEFINED` in tests.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
============================================
+ Coverage 89.43% 93.10% +3.67%
Complexity 293 293
============================================
Files 55 53 -2
Lines 965 943 -22
Branches 25 26 +1
============================================
+ Hits 863 878 +15
+ Misses 94 56 -38
- Partials 8 9 +1 🚀 New features to boost your workflow:
|
alexander-yevsyukov
changed the title
LocalDateValidatorLocalDateValidator and year field ranges
armiol
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates Time to latest version of Validation, which offers
MessageValidators.LocalDateValidatorwas implemented to offer day of month validation regarding number of days per month, including support for February 29th in leap years.Other notable changes
(validate) = trueon the nested date/time fields. We assume valid instances provided to the outer message construction. There is no need to re-validate the fields.yearfields inLocalDateandYearMonthtypes got min/max value offered by Java Time'sYearclass. We want our data types to be compatible with Java Time limits.