Remove runtime options subpackage#276
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes parts of the runtime validation surface from Validate and bumps the project snapshot version to 2.0.0-SNAPSHOT.402.
Changes:
- Bump project version from
2.0.0-SNAPSHOT.401to2.0.0-SNAPSHOT.402in Gradle/Maven metadata. - Simplify
Validate.violationsOf(...)by removing runtime/options-based validation paths and deprecated helpers, delegating the fallback path toValidatorRegistry. - Update/remove tests and regenerate parts of
dependencies.mdto reflect the new snapshot.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
version.gradle.kts |
Updates the shared validationVersion snapshot. |
pom.xml |
Updates Maven project version to the new snapshot. |
jvm-runtime/src/main/java/io/spine/validation/Validate.java |
Removes runtime/options-based validation APIs and changes fallback validation behavior to use ValidatorRegistry. |
tests/runtime/src/test/kotlin/io/spine/validation/ValidateUtilitySpec.kt |
Removes the test that depended on the removed custom-constraints API. |
dependencies.md |
Updates multiple dependency report headers/timestamps to the new snapshot version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It duplicates the functionality of `OptionsProvider.registryWithAllOptions()`
... as no longer needed.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 56 out of 56 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
tests/validating/src/testFixtures/proto/spine/test/options/bytes_direction_option.proto:1
- Changing a Protobuf option/extension field number is a wire-compatibility breaking change. Even though this is under test fixtures, it can still break any serialized descriptor/options data or interop if anything else expects the previous number. Prefer keeping the original field number, and if the change is required (e.g., due to a collision), add a brief comment explaining why the number had to change.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 76 out of 76 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
tests/validating/src/testFixtures/proto/spine/test/options/bytes_direction_option.proto:1
- Changing the numeric tag of a Protobuf extension is a breaking change for any compiled descriptors (and any serialized
FileDescriptorSets) that refer to the old number. If this renumbering is intentional, consider reserving the previous tag (73827) in this.proto(or documenting the reason) to prevent accidental reuse and to make the change explicit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also: * Clarify that `Any` is unpacked before validation.
This PR removes the
io.spine.validation.optionpackage and other code which was responsible for runtime validation based on descriptors in Validation version 1.x.Other notable changes
Validate.violationsOf()now delegates toValidatorRegistryfor external messages.