Skip to content

Remove runtime options subpackage#276

Merged
alexander-yevsyukov merged 32 commits intomasterfrom
remove-runtime-options-subpackage
Mar 10, 2026
Merged

Remove runtime options subpackage#276
alexander-yevsyukov merged 32 commits intomasterfrom
remove-runtime-options-subpackage

Conversation

@alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Mar 9, 2026

This PR removes the io.spine.validation.option package and other code which was responsible for runtime validation based on descriptors in Validation version 1.x.

Other notable changes

  • Validate.violationsOf() now delegates to ValidatorRegistry for external messages.

Copilot AI review requested due to automatic review settings March 9, 2026 18:43
@alexander-yevsyukov alexander-yevsyukov self-assigned this Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes parts of the runtime validation surface from Validate and bumps the project snapshot version to 2.0.0-SNAPSHOT.402.

Changes:

  • Bump project version from 2.0.0-SNAPSHOT.401 to 2.0.0-SNAPSHOT.402 in Gradle/Maven metadata.
  • Simplify Validate.violationsOf(...) by removing runtime/options-based validation paths and deprecated helpers, delegating the fallback path to ValidatorRegistry.
  • Update/remove tests and regenerate parts of dependencies.md to reflect the new snapshot.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
version.gradle.kts Updates the shared validationVersion snapshot.
pom.xml Updates Maven project version to the new snapshot.
jvm-runtime/src/main/java/io/spine/validation/Validate.java Removes runtime/options-based validation APIs and changes fallback validation behavior to use ValidatorRegistry.
tests/runtime/src/test/kotlin/io/spine/validation/ValidateUtilitySpec.kt Removes the test that depended on the removed custom-constraints API.
dependencies.md Updates multiple dependency report headers/timestamps to the new snapshot version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 9, 2026 19:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 9, 2026 20:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 9, 2026 20:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/validating/src/testFixtures/proto/spine/test/options/bytes_direction_option.proto:1

  • Changing a Protobuf option/extension field number is a wire-compatibility breaking change. Even though this is under test fixtures, it can still break any serialized descriptor/options data or interop if anything else expects the previous number. Prefer keeping the original field number, and if the change is required (e.g., due to a collision), add a brief comment explaining why the number had to change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review March 10, 2026 16:21
Copilot AI review requested due to automatic review settings March 10, 2026 16:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 76 out of 76 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/validating/src/testFixtures/proto/spine/test/options/bytes_direction_option.proto:1

  • Changing the numeric tag of a Protobuf extension is a breaking change for any compiled descriptors (and any serialized FileDescriptorSets) that refer to the old number. If this renumbering is intentional, consider reserving the previous tag (73827) in this .proto (or documenting the reason) to prevent accidental reuse and to make the change explicit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Also:
 * Clarify that `Any` is unpacked before validation.
@alexander-yevsyukov alexander-yevsyukov merged commit 1928e0b into master Mar 10, 2026
8 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the remove-runtime-options-subpackage branch March 10, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants