Skip to content

Fix error message composition, update version for examples#278

Merged
alexander-yevsyukov merged 11 commits intomasterfrom
restore-required-option
Mar 12, 2026
Merged

Fix error message composition, update version for examples#278
alexander-yevsyukov merged 11 commits intomasterfrom
restore-required-option

Conversation

@alexander-yevsyukov
Copy link
Collaborator

This PR fixes the issue of the error message composition for the Required option. Also, the version of Validation was updated in the documentation code snippet.

Copilot AI review requested due to automatic review settings March 12, 2026 17:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes error message composition in FieldValidatingOption by using the correct source for the containing type name, and bumps the version to 2.0.0-SNAPSHOT.404 across version file and docs.

Changes:

  • Fix containingTypeName retrieval to use field.target() instead of descriptor
  • Bump validation version to 2.0.0-SNAPSHOT.404 in version file and docs

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
jvm-runtime/.../FieldValidatingOption.java Fix containing type resolution for error messages
version.gradle.kts Version bump
docs/.../adding-to-build.md Update version in docs
docs/_examples Update submodule reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review March 12, 2026 17:33
Copilot AI review requested due to automatic review settings March 12, 2026 17:33
@alexander-yevsyukov alexander-yevsyukov self-assigned this Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@alexander-yevsyukov alexander-yevsyukov merged commit 05c3cba into master Mar 12, 2026
11 of 12 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the restore-required-option branch March 12, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants