Open
Conversation
remove the "postinstall" "bower install" so that if this package in installed via npm for use in an app you don't need bower or end up with all of the dependencies installed. Update the read me to have devs run bower install.
update main so it's actually parsable by npm. Update reasonable versions used to build as the current karma requires a really old node
…this context we get isn't the window. Update the dist files to match the package.json and this helps make sure that folks get the right package.
$cookieStore is gone in angular 1.4+ So conver this to use $cookie and if that isn't availible and we were asked to persist, use local storage. This change helps when using electron as the cookie api on the document does not persist and $cookie uses that under the hood. There are other solutions the swizzle the setter for document cookies under electron but local storage is what we're wanting to use. If you have a need to mock, then using local storage isn't going to be your friend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the "postinstall" "bower install" so that if this package is installed via npm for use in an app you don't require bower or end up with all of the dependencies installed. Updated the read me to have devs run bower install.
For bonus points it would be great if you posed this package on npm!