Fix symbol collision with other native gems using libzstd#104
Merged
Conversation
- Hide all ZSTD symbols by default using -fvisibility=hidden - Use exported_symbols_list on macOS to explicitly control exported symbols - Only export Init_zstdruby function required for Ruby extension initialization - Add RUBY_FUNC_EXPORTED macro to Init_zstdruby function This resolves symbol collision issues when using zstd-ruby alongside other gems that dynamically link to system libzstd (e.g., rdkafka-ruby). Fixes #102
|
This has been working out great for us in prod 🚢 |
Owner
Author
|
I’ll keep this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the symbol collision issue reported in #102 when using zstd-ruby alongside other gems that dynamically link to system libzstd (e.g., rdkafka-ruby).
Changes Made
Root Cause
The issue was caused by zstd-ruby exporting all ZSTD symbols globally, which created conflicts when other gems expected to use system libzstd. This resulted in memory corruption and segmentation faults.
Solution
With this fix, only the function is exported, preventing symbol collisions while maintaining full compatibility with existing functionality.
Testing
Fixes #102